Use Eigen CMake target #1058
Merged
Use Eigen CMake target #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
fmauch,
progtologist and
saikishor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
===========================================
+ Coverage 47.71% 72.16% +24.44%
===========================================
Files 41 41
Lines 3871 3639 -232
Branches 1833 1781 -52
===========================================
+ Hits 1847 2626 +779
+ Misses 751 700 -51
+ Partials 1273 313 -960
Flags with carried forward coverage won't be shown. Click here to find out more. |
fmauch
approved these changes
Feb 26, 2024
bmagyar
approved these changes
Mar 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
(cherry picked from commit 7d38fb9)
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
(cherry picked from commit 7d38fb9)
This was referenced Mar 1, 2024
bmagyar
pushed a commit
that referenced
this pull request
Mar 2, 2024
bmagyar
pushed a commit
that referenced
this pull request
Mar 2, 2024
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the CMake file to use Eigen's CMake target as described here https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html
See ros-controls/control_toolbox#178 for the issues with RHEL 8.